refactor: improve PythagoreanTriple logic and add parameterized tests #6350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6350 +/- ##
============================================
+ Coverage 74.55% 74.59% +0.04%
- Complexity 5452 5453 +1
============================================
Files 682 682
Lines 19033 19030 -3
Branches 3688 3683 -5
============================================
+ Hits 14190 14196 +6
+ Misses 4278 4271 -7
+ Partials 565 563 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
siriak
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the implementation and testing of the PythagoreanTriple utility class.
Changes include:
isPythagTriplemethod for better readability and validation.This enhances code quality, robustness, and maintainability.
clang-format -i --style=file path/to/your/file.java