Skip to content

refactor: refactor Alphabetical and AlphabeticalTest #6355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2025

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 8, 2025

  • Replaced imperative test logic in AlphabeticalTest with a @CsvSource-based parameterized test.

  • Improved test readability and maintainability.

  • Migrated hardcoded tests from main() in Alphabetical class into proper unit tests.

  • Cleaned up unused main() method from Alphabetical utility class, aligning with test-driven structure.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (22cba2c) to head (f7e4c7c).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6355      +/-   ##
============================================
+ Coverage     74.60%   74.62%   +0.02%     
- Complexity     5450     5451       +1     
============================================
  Files           682      682              
  Lines         19024    19017       -7     
  Branches       3677     3674       -3     
============================================
- Hits          14193    14192       -1     
+ Misses         4271     4265       -6     
  Partials        560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work.

@DenizAltunkapan DenizAltunkapan merged commit f325279 into TheAlgorithms:master Jul 10, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants