Skip to content

Making the median calculating part safe from integer spillovers #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Making the median calculating part safe from integer spillovers #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/main/java/com/search/BinarySearch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,38 @@

/**
* Binary search is an algorithm which finds the position of a target value within a sorted array
*
* <p>
* Worst-case performance O(log n)
* Best-case performance O(1)
* Average performance O(log n)
* Worst-case space complexity O(1)
*/
public final class BinarySearch{
public final class BinarySearch {

/**
* @param array is an array where the element should be found
* @param key is an element which should be found
* @param <T> is any comparable type
* @param key is an element which should be found
* @param <T> is any comparable type
* @return index of the element
*/
public static <T extends Comparable<T>> int findIndex(T array[], T key) {
return search(array, key, 0, array.length-1);
public static <T extends Comparable<T>> int findIndex(T[] array, T key) {
return search(array, key, 0, array.length - 1);
}

/**
* @param array The array to search
* @param key The element you are looking for
* @param left The lower bound
* @param key The element you are looking for
* @param left The lower bound
* @param right The upper bound
* @return the location of the key
**/
private static <T extends Comparable<T>> int search(T array[], T key, int left, int right){
private static <T extends Comparable<T>> int search(T[] array, T key, int left, int right) {
if (left > right) {
return -1; // Key not found
}

// Find median
int median = (left + right)/2;
int median = left + (right - left) / 2;
int comp = key.compareTo(array[median]);

if (comp < 0) {
Expand Down