Efficiency #732
Merged
Efficiency #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just two small things that in case the number was very big could be helpful.
|
I have been testing both ways to do it measuring time. Both are very fast and truly this pull request doesn't fix anything very important, but when the computer is working in other things and interrupts the thread, in your case you have a small delay. On the other hand, my solution makes it an atomic operation. |
havanagrawal
reviewed
May 2, 2019
ciphers/Caesar.java
Outdated
| @@ -24,8 +24,8 @@ | |||
| public static String encode(String message, int shift) { | |||
| String encoded = ""; | |||
|
|
|||
| while (shift >= 26) { // 26 = number of latin letters | |||
| shift -= 26; | |||
| if (shift >= 26) { // 26 = number of latin letters | |||
There was a problem hiding this comment.
Good catch! In fact, even this if is not necessary, since the modulo operation is no-op if shift < 26, i.e.
shift % 26 == shift if 0 <= shift < 26
There was a problem hiding this comment.
Oh! That's true! Less code then :)
|
LGTM :) |
yanglbme
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just two small things that in case the number was very big could be helpful.