Skip to content

Fix for Issue #773. Deleting an element that doesn't exist causes NPE #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2019
Merged

Fix for Issue #773. Deleting an element that doesn't exist causes NPE #774

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7eb0785
Fix for Issue #773. Deleting an element that doesn't exist causes NPE
abhijaykumar May 30, 2019
9b78621
Revert "Fix for Issue #773. Deleting an element that doesn't exist ca…
abhijaykumar May 30, 2019
b6581ea
Fix for Issue #773. Deleting an element that doesn't exist causes NPE
abhijay94 May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions DataStructures/Lists/DoublyLinkedList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,13 @@ public Link deleteTail() {
public void delete(int x) {
Link current = head;

while (current.value != x) // Find the position to delete
current = current.next;
while (current.value != x) {// Find the position to delete
if (current != tail) {
current = current.next;
} else {// If we reach the tail and the element is still not found
throw new RuntimeException("The element to be deleted does not exist!");
}
}

if (current == head)
deleteHead();
Expand Down