Skip to content

More accurate error message at IsDivisible #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2022
Merged

More accurate error message at IsDivisible #1048

merged 2 commits into from
Jun 21, 2022

Conversation

Rudxain
Copy link
Contributor

@Rudxain Rudxain commented Jun 20, 2022 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

This PR edits the error message in that file (Maths/IsDivisible.js) to be more accurate to its context. Because Infinity and NaN aren't valid Real numbers.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@appgurueu appgurueu added the code quality Code quality improvement label Jun 21, 2022
appgurueu
appgurueu previously approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(consider lowercasing the r from real)

@Rudxain
Copy link
Contributor Author

Rudxain commented Jun 21, 2022

(consider lowercasing the r from real)

Why? I thought it was a good idea to make it uppercase to distinguish between "real" (reality) and "Real" (the set of all non-complex rational and irrational numbers). But, for consistency, it may also be a good idea to lowercase it

@appgurueu
Copy link
Collaborator

Why? I thought it was a good idea to make it uppercase to distinguish between "real" (reality) and "Real" (the set of all non-complex rational and irrational numbers). But, for consistency, it may also be a good idea to lowercase it

"real number" already is an unambiguous term and thus fine - no need to bend the rules of capitalization to emphasize the "real" property.

@Rudxain
Copy link
Contributor Author

Rudxain commented Jun 21, 2022

Ok then I'll change it now

@raklaptudirm raklaptudirm merged commit 95a8ec0 into TheAlgorithms:master Jun 21, 2022
@Rudxain Rudxain deleted the patch-1 branch June 21, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
code quality Code quality improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rudxain @appgurueu @raklaptudirm