Skip to content

Fix IsPalindrome Big-O analysis #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Fix IsPalindrome Big-O analysis #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74c59d5
Fix IsPalindrome Big-O analysis
appgurueu Jul 1, 2022
2d43558
Updated Documentation in README.md
Jul 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DIRECTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@
* [FormatPhoneNumber](String/FormatPhoneNumber.js)
* [GenerateGUID](String/GenerateGUID.js)
* [HammingDistance](String/HammingDistance.js)
* [IsPalindrome](String/IsPalindrome.js)
* [KMPPatternSearching](String/KMPPatternSearching.js)
* [LevenshteinDistance](String/LevenshteinDistance.js)
* [Lower](String/Lower.js)
Expand Down
3 changes: 2 additions & 1 deletion String/IsPalindrome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
* Big-O Analysis
* Time Complexity
- O(N) on average and worst case scenario as input is traversed in linear fashion
- O(N) on best case scenario, even when input has length of 1, because toString() method takes O(N)
- O(1) on best case scenario if the input already is a string (otherwise toString() method takes O(N))
and the first & last characters don't match, triggering an early return
* Space Complexity
- O(1)
*/
Expand Down