Skip to content

merge: Fix GetEuclidGCD (#1068) #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2022
Merged

merge: Fix GetEuclidGCD (#1068) #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DIRECTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
* **Cellular-Automata**
* [ConwaysGameOfLife](Cellular-Automata/ConwaysGameOfLife.js)
* **Ciphers**
* [AffineCipher](Ciphers/AffineCipher.js)
* [Atbash](Ciphers/Atbash.js)
* [CaesarsCipher](Ciphers/CaesarsCipher.js)
* [KeyFinder](Ciphers/KeyFinder.js)
Expand Down
42 changes: 15 additions & 27 deletions Maths/GetEuclidGCD.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,20 @@
/*
Problem statement and Explanation : https://en.wikipedia.org/wiki/Euclidean_algorithm

In this method, we have followed the iterative approach to first
find a minimum of both numbers and go to the next step.
*/

/**
* GetEuclidGCD return the gcd of two numbers using Euclidean algorithm.
* @param {Number} arg1 first argument for gcd
* @param {Number} arg2 second argument for gcd
* @returns return a `gcd` value of both number.
* GetEuclidGCD Euclidean algorithm to determine the GCD of two numbers
* @param {Number} a integer (may be negative)
* @param {Number} b integer (may be negative)
* @returns {Number} Greatest Common Divisor gcd(a, b)
*/
const GetEuclidGCD = (arg1, arg2) => {
// firstly, check that input is a number or not.
if (typeof arg1 !== 'number' || typeof arg2 !== 'number') {
return new TypeError('Argument is not a number.')
export function GetEuclidGCD (a, b) {
if (typeof a !== 'number' || typeof b !== 'number') {
throw new TypeError('Arguments must be numbers')
}
// check that the input number is not a negative value.
if (arg1 < 1 || arg2 < 1) {
return new TypeError('Argument is a negative number.')
if (a === 0 && b === 0) return undefined // infinitely many numbers divide 0
a = Math.abs(a)
b = Math.abs(b)
while (b !== 0) {
const rem = a % b
a = b
b = rem
}
// Find a minimum of both numbers.
let less = arg1 > arg2 ? arg2 : arg1
// Iterate the number and find the gcd of the number using the above explanation.
for (less; less >= 2; less--) {
if ((arg1 % less === 0) && (arg2 % less === 0)) return (less)
}
return (less)
return a
}

export { GetEuclidGCD }