Skip to content

Edit Perfect{Square, Cube} #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 12, 2022
Merged

Edit Perfect{Square, Cube} #1071

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
39e3c83
Make `PerfectCube` more correct and readable
Rudxain Jul 28, 2022
c788dcb
Add negative and Infinity tests
Rudxain Jul 28, 2022
b7743e1
Fixed comment formatting
Rudxain Jul 28, 2022
e5b5cf6
Realized BigInt support is unnecessary
Rudxain Jul 28, 2022
bbdf16f
Update PerfectCube.js
Rudxain Jul 28, 2022
03008e4
Remove space
Rudxain Jul 28, 2022
188a16e
Merge branch 'TheAlgorithms:master' into patch-1
Rudxain Aug 4, 2022
c1210aa
Update PerfectCube.js
Rudxain Aug 4, 2022
2491d25
Update PerfectCube.js
Rudxain Aug 4, 2022
7d0e2db
Parity between `PerfectSquare` and `PerfectCube`
Rudxain Aug 4, 2022
cc4e44e
Update PerfectSquare.test.js
Rudxain Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Maths/PerfectCube.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
* Author: dephraiim
* License: GPL-3.0 or later
*
* This uses `round` instead of `floor` or `trunc`, to guard against potential `cbrt` accuracy errors
*/

const perfectCube = (num) => Math.round(num ** (1 / 3)) ** 3 === num
const perfectCube = (num) => Number.isFinite(num) && Math.round(Math.cbrt(num)) ** 3 === num

export { perfectCube }
3 changes: 2 additions & 1 deletion Maths/PerfectSquare.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
* Author: dephraiim
* License: GPL-3.0 or later
*
* This uses `round` instead of `floor` or `trunc`, to guard against potential `sqrt` accuracy errors
*/

const perfectSquare = (num) => Math.sqrt(num) ** 2 === num
const perfectSquare = (num) => Number.isFinite(num) && Math.round(Math.sqrt(num)) ** 2 === num

export { perfectSquare }
2 changes: 2 additions & 0 deletions Maths/test/PerfectCube.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ import { perfectCube } from '../PerfectCube'
describe('PerfectCube', () => {
it('should return true for a perfect cube', () => {
expect(perfectCube(125)).toBeTruthy()
expect(perfectCube(-125)).toBeTruthy()
})
it('should return false for a non perfect cube', () => {
expect(perfectCube(100)).toBeFalsy()
expect(perfectCube(Infinity)).toBeFalsy()
})
})
5 changes: 3 additions & 2 deletions Maths/test/PerfectSquare.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { perfectSquare } from '../PerfectSquare'

describe('PerfectSquare', () => {
it('should return true for a perfect cube', () => {
it('should return true for a perfect square', () => {
expect(perfectSquare(16)).toBeTruthy()
})
it('should return false for a non perfect cube', () => {
it('should return false for a non perfect square', () => {
expect(perfectSquare(10)).toBeFalsy()
expect(perfectSquare(Infinity)).toBeFalsy()
})
})