Skip to content

Fix Affine-Cipher encrypt and drypt func #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shidian00
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • encrypt func should return alphabet instead of numbers string

  • add checking for coprime as if coefficient 'a' is not coprime to 26 will reusultant in invalid result in inverse mod

  • modify some test case

  • Add an algorithm?

  • Fix a bug or typo in an existing algorithm?

  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@shidian00 shidian00 requested a review from appgurueu August 3, 2022 03:47
@raklaptudirm raklaptudirm merged commit 4b07e8a into TheAlgorithms:master Aug 3, 2022
@appgurueu appgurueu added the fix Fixes a bug label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants