Skip to content

algorithm: Hexagonal number #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2022
Merged

algorithm: Hexagonal number #1265

merged 3 commits into from
Nov 30, 2022

Conversation

itsAkshayDubey
Copy link
Contributor

@itsAkshayDubey itsAkshayDubey commented Nov 25, 2022 •
edited by gitpod-io bot
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu approved these changes Nov 25, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, although just implementing such a formula is pretty trivial.

@raklaptudirm
Copy link
Member

@appgurueu Do you think it's too trivial and unremarkable to be merged?

@appgurueu
Copy link
Collaborator

@appgurueu Do you think it's too trivial and unremarkable to be merged?

Not sure. This does appear in some Project Euler problems and it is a well-known definition, so I say let's keep it (comparable to trivial math funcs like signum I'd say).

@raklaptudirm raklaptudirm merged commit d6be3a4 into TheAlgorithms:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsAkshayDubey @raklaptudirm @appgurueu