Skip to content

Added a new Maths algorithm to determine if two non-null integers are "friendly numbers" #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

fun-guava
Copy link
Contributor

@fun-guava fun-guava commented Nov 27, 2022

Open in Gitpod know more

Describe your change:

Added a new FriendlyNumbers.js file, with a Maths algorith to determine if two integers are friendly numbers. Friendaly number are defined as follows (source wikipedia): 'In number theory, friendly numbers are two or more natural numbers with a common abundancy index, the ratio between the sum of divisors of a number and the number itself.'
This is my first ever real pull request as I am totally new to git and gitHub. Please don't hesitate to let me now if I am not following the proper procedure.

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Nov 27, 2022
@raklaptudirm raklaptudirm merged commit 18a9157 into TheAlgorithms:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Adds or improves an algorithm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants