Skip to content

feat: Added speed unit conversion functionality #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Added speed unit conversion functionality #1450

wants to merge 2 commits into from

Conversation

Hyraze
Copy link

@Hyraze Hyraze commented Oct 5, 2023 •
edited
Loading

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Hyraze Hyraze changed the title feat:added SpeedConversion.js feat: Add speed unit conversion functionality Oct 5, 2023
@Hyraze Hyraze changed the title feat: Add speed unit conversion functionality feat: Added speed unit conversion functionality Oct 7, 2023
appgurueu
appgurueu requested changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have https://github.com/TheAlgorithms/JavaScript/blob/master/Conversions/LengthConversion.js, and I don't really see what this adds in contrast. If anything, you should generalize the "conversion" to take the unit table as a parameter, such that both speed and length conversions would be using the same code.

(Speed units actually consist of two units, though: a length unit divided by a time unit, and the code should ideally reflect that).

@Hyraze
Copy link
Author

Hyraze commented Oct 8, 2023 •
edited
Loading

We already have https://github.com/TheAlgorithms/JavaScript/blob/master/Conversions/LengthConversion.js, and I don't really see what this adds in contrast. If anything, you should generalize the "conversion" to take the unit table as a parameter, such that both speed and length conversions would be using the same code.

(Speed units actually consist of two units, though: a length unit divided by a time unit, and the code should ideally reflect that).

Got it. Will be sending the unit type as a parameter in the new common conversion.js Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm raklaptudirm is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hyraze @appgurueu