Skip to content

Conversation

AbhineshJha
Copy link
Contributor

@AbhineshJha AbhineshJha commented Oct 5, 2023

Describe your change:

@AbhineshJha
Copy link
Contributor Author

AbhineshJha commented Oct 6, 2023

please review @raklaptudirm @appgurueu

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting the Hacktoberfest website:

Avoid submitting low-quality pull/merge requests.

This is a fix for a typo in a comment. It doesn't affect the code or even the meaning of the comment at all. I'm afraid this pretty much makes it a textbook low quality contribution.

We do welcome chores like fixing typos, but please do them in bulk to reduce overhead, and don't expect them to count towards your Hacktoberfest score.

@appgurueu appgurueu added the hacktoberfest-invalid not eligible to count towards hacktoberfest points label Oct 7, 2023
@raklaptudirm
Copy link
Member

@appgurueu Even though this can't be accepted for hacktoberfest please approve the changes so we can merge.

@AbhineshJha
Copy link
Contributor Author

AbhineshJha commented Oct 7, 2023

sorry for inconvenience @appgurueu ! I am new to open source , i am in the learning period , next time this will not happen

@AbhineshJha
Copy link
Contributor Author

hey @raklaptudirm merge this !!

@appgurueu
Copy link
Collaborator

sorry for inconvenience @appgurueu ! I am new to open source , i am in the learning period , next time this will not happen

That's fine. I suggest you to carefully reread the Hacktoberfest site to know the "rules" as a participant.

I will merge this for now (but I don't think it will count towards Hacktoberfest, given the label matching \binvalid\b), but in the future, please don't make PRs to fix single typos; it has way too much overhead. If you do decide to fix typos, fix multiple in one go.

@appgurueu appgurueu merged commit da0ee87 into TheAlgorithms:master Oct 7, 2023
@AbhineshJha AbhineshJha deleted the GrammarError branch October 7, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-invalid not eligible to count towards hacktoberfest points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER]: Grammar Mistake
4 participants