Skip to content

Improved SieveOfEratosthenes.js #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from May 23, 2021
Merged

Improved SieveOfEratosthenes.js #351

merged 1 commit into from May 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2020

Welcome to JavaScript community

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?
  • Improve an existing algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@c-utkarsh
Copy link
Contributor

Hi @jimmyjoo, this improvement has already been proposed in Pull Request #299.

@ghost
Copy link
Author

ghost commented Oct 2, 2020

@c-utkarsh Hi 😃 I didn't catch that but I thought I was the one in charged of optimizing this algorithm. (Issue #290)

@stale
Copy link

stale bot commented Feb 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Will not be fixed or is a feature label Feb 14, 2021
@stale
Copy link

stale bot commented Feb 21, 2021

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale bot closed this Feb 21, 2021
@raklaptudirm raklaptudirm reopened this May 23, 2021
@stale stale bot removed the wontfix Will not be fixed or is a feature label May 23, 2021
@raklaptudirm
Copy link
Member

I am taking this in favor instead of #299 because of the comment explanation.

@raklaptudirm raklaptudirm merged commit 38a5cb2 into TheAlgorithms:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-utkarsh @raklaptudirm @jimmyjoo