Skip to content

Conversation

ms10398
Copy link
Member

@ms10398 ms10398 commented Aug 4, 2017

No description provided.

@ms10398
Copy link
Member Author

ms10398 commented Aug 5, 2017

Implementation of BST

Copy link
Member

@r0hit-gupta r0hit-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks really good to me. But here is something I would like to you to consider:

  1. Please provide a meaningful name to the file. bst.js is not a good choice in my opinion.

  2. Add a proper response when searched element is not found in the tree.

@ms10398
Copy link
Member Author

ms10398 commented Aug 5, 2017

Thanks for suggestion

  • Changed the file name to appropriate file name
  • Added proper response if item not found

@ms10398
Copy link
Member Author

ms10398 commented Aug 7, 2017

Should I add anything more to the Binary Search Tree Implementation

@r0hit-gupta r0hit-gupta merged commit c352f44 into TheAlgorithms:master Aug 7, 2017
@r0hit-gupta
Copy link
Member

No. This is good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants