Skip to content

Add tests and docs for the Longest Common Subsequence algorithm #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 8, 2021
Merged

Add tests and docs for the Longest Common Subsequence algorithm #867

merged 5 commits into from
Dec 8, 2021

Conversation

zaaath
Copy link
Contributor

@zaaath zaaath commented Dec 6, 2021 •
edited
Loading

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

Adds tests and docs as well as refactors the Longest Common Subsequence algorithm

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@zaaath zaaath requested a review from raklaptudirm as a code owner December 6, 2021 18:19
@zaaath zaaath changed the title Longest common subsequence algorithm refactoring Add tests and docs for the Longest common subsequence algorithm Dec 6, 2021
@zaaath zaaath changed the title Add tests and docs for the Longest common subsequence algorithm Add tests and docs for the Longest Common Subsequence algorithm Dec 6, 2021
@raklaptudirm raklaptudirm added feature Adds a new feature Reviewed labels Dec 8, 2021
@raklaptudirm raklaptudirm merged commit 7560beb into TheAlgorithms:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaaath @raklaptudirm