improve median #869
Merged
improve median #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
'I believe the previous implementation was more concise and to the point' - no problem === |
raklaptudirm
requested changes
Dec 20, 2021
raklaptudirm
requested changes
Dec 20, 2021
raklaptudirm
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Fix a bug
In the last implementation, finding the median is not a pure function. It mutates the original array.
const arr = [3,2,1]
averageMedian(arr)
numbers = numbers.sort(sortNumbers)so arr will be [1,2,3].
Why? The function for finding the median should not change arr by sorting
====
Now this fn can work with generators and custom median selector (for example of str lengths)