Skip to content

Improving the coding standard for AvLTree Data Structure #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 17, 2022
Merged

Improving the coding standard for AvLTree Data Structure #882

merged 6 commits into from
Feb 17, 2022

Conversation

rahulrajrd
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

raklaptudirm
raklaptudirm requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a /test sub-directory and write some jest tests for the algorithm there. I know they were not there, but they will further enhance the code quality and help catch bugs.

@rahulrajrd
Test case creation for AVLTree
f19fff8 
~ Created test cases for AVL Tree
~ Indentation fix for AVLTree.js
@rahulrajrd
Copy link
Contributor Author

Please create a /test sub-directory and write some jest tests for the algorithm there. I know they were not there, but they will further enhance the code quality and help catch bugs.

The test cases are created

@rahulrajrd rahulrajrd closed this Feb 16, 2022
@rahulrajrd rahulrajrd reopened this Feb 16, 2022
raklaptudirm
raklaptudirm requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing, so please check the error and fix them.

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature labels Feb 16, 2022
github-actions and others added 2 commits February 16, 2022 09:21
@rahulrajrd
Copy link
Contributor Author

rahulrajrd commented Feb 16, 2022 •
edited
Loading

The tests are failing, so please check the error and fix them.

Test cases are working properly in local without any issues

image

@rahulrajrd rahulrajrd closed this Feb 16, 2022
@rahulrajrd rahulrajrd reopened this Feb 16, 2022
@raklaptudirm
Copy link
Member

Please check if you have any local changes which you have not yet committed.

raklaptudirm
raklaptudirm requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your code with standard.js.

@raklaptudirm raklaptudirm merged commit c9701e8 into TheAlgorithms:master Feb 17, 2022
@rahulrajrd rahulrajrd deleted the improving-coding-standard-of-AVLTree-Data-structure branch April 7, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulrajrd @raklaptudirm