Skip to content

merge: Upgrade Lower function #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 19, 2022
Merged

merge: Upgrade Lower function #894

merged 5 commits into from
Feb 19, 2022

Conversation

fahimfaisaal
Copy link
Contributor

Welcome to JavaScript community

Open in Gitpod know more

Describe your change:

  • Optimize the Lower.js algo via using regex and String.prototype.replace method.
  • Update some js doc.
  • Add four new test cases.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not

raklaptudirm
raklaptudirm requested changes Feb 19, 2022
View reviewed changes
@fahimfaisaal
Copy link
Contributor Author

Done

@raklaptudirm raklaptudirm added algorithm Adds or improves an algorithm feature Adds a new feature labels Feb 19, 2022
@raklaptudirm raklaptudirm merged commit 041918d into TheAlgorithms:master Feb 19, 2022
@fahimfaisaal fahimfaisaal deleted the upgrade-lower branch March 29, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fahimfaisaal @raklaptudirm