Skip to content

Fix wiggle sort #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2022
Merged

Conversation

BranAndSceolan
Copy link
Contributor

Welcome to the JavaScript community

Open in Gitpod know more

Describe your change:

Fixes: #988
Renamed the algorithm "simplified wiggle-sort", because traditional wiggle-sort demands arr[0] < arr[1] > arr[2] < arr[3] > arr[4] <... but this version only demands arr[0] <= arr[1] >= arr[2] <= arr[3] >= arr[4] <= …
For strict wiggle-sort there could be made an own implementation.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • [] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Antonia Strack added 4 commits April 21, 2022 09:57
@appgurueu appgurueu added feature Adds a new feature algorithm Adds or improves an algorithm labels Apr 21, 2022
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper Jest tests rather than comments.

@BranAndSceolan
Copy link
Contributor Author

I have added tests now.

@raklaptudirm raklaptudirm requested a review from appgurueu April 21, 2022 14:04
fix typo:  wich => which
@appgurueu appgurueu merged commit 01db0fb into TheAlgorithms:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Adds or improves an algorithm feature Adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wiggle sort seems incorrect
3 participants