maths/radix2_fft.py: Fix calculation for Python 3.14 #12772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested at: * #12729 (comment) * #12710 (comment) @MaximSmolskiy @KirilBangachev @skirpichev Careful review, please. I am just implementing the suggestion, but I do not have any expertise in this area.
for more information, see https://pre-commit.ci
It is confusing to have two jobs named `build`.
cclauss
commented
May 28, 2025
| @@ -3,7 +3,7 @@ | |||
| name: directory_writer | |||
| on: [push] | |||
| jobs: | |||
| build: | |||
| directory_writer: | |||
There was a problem hiding this comment.
It is too confusing to have two GitHub Actions jobs named build, so rename this job to document what it really does.
MaximSmolskiy
approved these changes
May 28, 2025
skirpichev
approved these changes
May 29, 2025
|
Nice teamwork on this one. Thanks much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12729
As suggested at:
@MaximSmolskiy @KirilBangachev @skirpichev Careful review, please. I am just implementing the suggestion, but I do not have any expertise in this area.
Describe your change:
Checklist: