Skip to content

Fixing Some Minor Issues #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2019
Merged

Fixing Some Minor Issues #1386

merged 4 commits into from
Oct 17, 2019

Conversation

Cor3Down
Copy link
Contributor

I have fixed some minor issues in linear_algebra/src/lib.py

Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions but this looks good. Thanks!

"""
input: components or nothing
simple constructor for init the vector
"""
if components is None:
components = []
self.__components = list(components)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.__components = list(components or [])

@cclauss cclauss merged commit 63d8cad into TheAlgorithms:master Oct 17, 2019
@Cor3Down Cor3Down deleted the minor_fixes branch October 18, 2019 10:15
@Cor3Down
Copy link
Contributor Author

A few minor suggestions but this looks good. Thanks!

Thank you

stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Replacing mutable default argument in __init__

* Fixing typo mistakes in lib.py

* Simplifying chained comparisons

* Update lib.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants