Skip to content

consists of area of various geometrical shapes #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 18, 2020
Merged

consists of area of various geometrical shapes #2002

merged 4 commits into from
May 18, 2020

Conversation

Adityanagraj
Copy link
Contributor

@Adityanagraj Adityanagraj commented May 18, 2020 •
edited
Loading

In this program it consists of various area calculation of different geometrical shapes such as (square,rectangle) and many other shapes.

Describe your change:

added a new file area.py file

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Adityanagraj
consists of area of various geometrical shapes
71ce987 
In this program it consists of various area calculation of different geometrical shapes such as (square,rectangle) and many other shapes.
@Adityanagraj
Copy link
Contributor Author

Why merging is blocked

@cclauss
Copy link
Member

cclauss commented May 18, 2020

https://github.com/TheAlgorithms/Python/blob/master/Travis_CI_tests_are_failing.md
Please run the code through psf/black to fix whitespace issues.

@cclauss cclauss added the tests are failing Do not merge until tests pass label May 18, 2020
@cclauss cclauss closed this May 18, 2020
@cclauss cclauss reopened this May 18, 2020
@cclauss cclauss merged commit e6fdcc9 into TheAlgorithms:master May 18, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Adityanagraj @cclauss @stokhos
consists of area of various geometrical shapes (TheAlgorithms#2002)
1ff7e7d 
* consists of area of various geometrical shapes

In this program it consists of various area calculation of different geometrical shapes such as (square,rectangle) and many other shapes.

* print(f'Rectangle: {area_rectangle(10, 20)=}')

* Update area.py

* Areas of various geometric shapes:

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adityanagraj @cclauss