Added bead sort #2022
Merged
Added bead sort #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
requested changes
May 21, 2020
sorts/bead_sort.py
Outdated
|
|
||
| def bead_sort(sequence: list) -> list: | ||
| """ | ||
| >>> bead_sort([6,11, 12, 4, 1, 5]) |
There was a problem hiding this comment.
Suggested change
| >>> bead_sort([6,11, 12, 4, 1, 5]) | |
| >>> bead_sort([6, 11, 12, 4, 1, 5]) |
There was a problem hiding this comment.
Please test [1, .9, 0.0, 0, -1, -.9] and "Hello World!"
There was a problem hiding this comment.
I am wondering on "Hello world" ordering. Theory says that algorithm should be use for positive integers. I think checking types inside sort function is not efficient.
There was a problem hiding this comment.
After a few moments, I decide to write two checks for it. I don't want to argue with the theory! 😄 @cclauss maybe you have a better idea for this?
cclauss
reviewed
May 21, 2020
sorts/bead_sort.py
Outdated
Comment on lines
28
to
32
| if isinstance(sequence, str): | ||
| raise TypeError("Sequence must be list of positive integers") | ||
|
|
||
| if min(sequence) < 0: | ||
| raise TypeError("Sequence must be list of positive integers") |
There was a problem hiding this comment.
Why not sort these things? They should work just fine.
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
* Added bead sort * Commit suggestion * Added checking before sort * Bead sort only works for sequences of nonegative integers Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added bead sort aka gravity sort
Checklist:
Fixes: #{$ISSUE_NO}.