Skip to content

Adding Simpler Solutions Project Euler #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Adding Simpler Solutions Project Euler #335

wants to merge 5 commits into from

Conversation

satanb4
Copy link
Contributor

@satanb4 satanb4 commented Aug 13, 2018

A simpler code has been added to project euler #16

Added question for new solution
This reverts commit 1b6b732.
Added 3 line code for solving question 16 of Project Euler
@AnshulMalik
Copy link
Member

@sayan97 Awesome, it'd really help if you add some comments telling what it does or simplify it a bit, so that it's easy to understand. :)

@satanb4
Copy link
Contributor Author

satanb4 commented Sep 28, 2018

Uses list comprehension to decrease the time complexity and speeds up the overall program.

Copy link

@seamountzh seamountzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out and inner variable are same,will they effect each other?

@satanb4
Copy link
Contributor Author

satanb4 commented Feb 5, 2019

Variable declaration is not taking place. Works as iterator like in generators.

@satanb4 satanb4 closed this Feb 5, 2019
@satanb4 satanb4 reopened this Feb 5, 2019
@cclauss
Copy link
Member

cclauss commented Sep 10, 2019

This solution seems incompatible with the other solution.
https://github.com/TheAlgorithms/Python/blob/26b2e60792f19a66dbd7e38f91a5b8febfdbc740/Project%20Euler/Problem%2016/sol1.py
Could we have prompts in the input() calls so the user knows what is expected? The current version would hang out automated testing.

@satanb4 satanb4 closed this Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants