Skip to content

Iterative fibonacci with unittests from slash #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 8, 2019
Merged

Iterative fibonacci with unittests from slash #882

merged 11 commits into from
Jun 8, 2019

Conversation

StephenGemin
Copy link
Contributor

This is a duplicate of the request #866 , I couldn't figure how to add it to the request, so I'm creating a new pull request. I've included the changes using the iterative fibonacci. First pull request, so any feedback is appreciated :D.

--Added two ways to calculate the fibonacci sequence: (1) iterative (2) formula.
--I've also added a timer decorator so someone can see the difference in computation time between these two methods.
--Added two unittests using the slash framework.

Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to separate tests out, but I'd merge this as this is indeed a new approach.
Thank you for your pull request!🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants