Skip to content

Added: Degree to Radian conversion #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2022
Merged

Added: Degree to Radian conversion #46

merged 4 commits into from
Oct 10, 2022

Conversation

MohdFaisalBidda
Copy link
Contributor

  • Degree to Radian conversion

appgurueu
appgurueu requested changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use parseFloat and toFixed here, just multiply by Math.PI/180

appgurueu
appgurueu reviewed Oct 9, 2022
View reviewed changes
appgurueu
appgurueu reviewed Oct 9, 2022
View reviewed changes
appgurueu
appgurueu previously approved these changes Oct 9, 2022
View reviewed changes
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider renaming to degreesToRadians

@MohdFaisalBidda
Copy link
Contributor Author

MohdFaisalBidda commented Oct 9, 2022 •
edited
Loading

Should I change the file name and function name or only the function name to degreesToRadians

@raklaptudirm raklaptudirm merged commit eca3906 into TheAlgorithms:master Oct 10, 2022
@MohdFaisalBidda MohdFaisalBidda deleted the Branch2 branch October 10, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu appgurueu approved these changes

@raklaptudirm raklaptudirm raklaptudirm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MohdFaisalBidda @appgurueu @raklaptudirm