Skip to content

Commit

Permalink
Ruby: Event Manager: Run markdownlint autofixer (#27994)
Browse files Browse the repository at this point in the history
* Run fixer on event manager lesson

* Add the ruby codeblocks to ignore HTML blankline rule

* Fix spacing in HTML string in ruby codeblock

* Fix lazy numbering issue

* Update links for accessibility

* Add "javascript" to ignore list  on TOP005

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Add test for javascript code blocks ignoring TOP005

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Remove inline codeblocks within link

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Fix filename formatting

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Fix filename formatting

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Remove inline codeblocks inside of link

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Fix format for filename

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Fix "google" typo

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Match other href's link text

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Move open source note to the introduction section

* Remove unnecessary leading spaces

* Join unnecessary line breaks throughout lesson

* Fix leading spacing in note

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Add inline code for ruby's `File` class.

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Add inline code for `first_Name` csv column

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Add inline code for CSV columns

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Add inline code for `nil`

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

* Use inline code for directory names

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

---------

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
  • Loading branch information
JoshDevHub and MaoShizhong authored May 19, 2024
1 parent 347e6f3 commit ccf26c4
Show file tree
Hide file tree
Showing 3 changed files with 225 additions and 450 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = {
* We only want to flag HTML tags we use for actual markup,
* or md code block examples of such.
*/
const IGNORED_FENCE_TYPES = ["html", "jsx", "erb", "ejs"];
const IGNORED_FENCE_TYPES = ["html", "jsx", "erb", "ejs", "ruby", "javascript"];
const ignoredFencesLineRanges = params.tokens
.filter((token) => {
return token.type === "fence" && IGNORED_FENCE_TYPES.includes(token.info);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,20 @@ This line above the closing tag is not a blank line nor a code block delimiter,
<% } %>
```

```ruby
if ruby?
html_fragment = <<~HTML
<p>Does not flag when used in ruby code blocks</p>
HTML
end
```

```javascript
const htmlString = `
<p>Does not flag when used in JavaScript code blocks, e.g. template literals.</p>
`;
```

```markdown
<p>
But does not like it if done in a non-HTML/JSX code block
Expand Down
Loading

0 comments on commit ccf26c4

Please sign in to comment.