Skip to content

fix: add exported member depth picking pass pmndrs #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

damienmontastier
Copy link
Member

The DepthPickingPassPmndrs export was removed by mistake, causing issues with ShockWave.
This PR restores it to ensure proper functionality.

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @damienmontastier

Just small feedback for the future, the tresleches refactor should have lived in a separate PR to ensure small scope, is not really related to the PR title nor the description.

@damienmontastier damienmontastier force-pushed the fix/add-exported-member-depthPickingPassPmndrs branch from eb6f7e9 to d6d5594 Compare January 30, 2025 19:51
Copy link

pkg-pr-new bot commented Jan 30, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/post-processing@179

commit: b33ad3f

@damienmontastier
Copy link
Member Author

@alvarosabu It's a mistake on my part, I reverted to the main branch.

@alvarosabu alvarosabu added feature p3-significant High-priority enhancement (priority) bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) and removed feature p3-significant High-priority enhancement (priority) labels Jan 31, 2025
@alvarosabu alvarosabu merged commit 6f3d459 into main Jan 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority)
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants