fix: god rays async light source #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Tinoooo
requested changes
Mar 28, 2025
Tinoooo
reviewed
Mar 28, 2025
Tinoooo
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a light source issue (Discord message) in
<GodRaysPmndrs>. The source (mesh or point) wasn't handling async creation properly, causing missing or incorrect GodRays.Godrays doesn't accept null lightSource (only
Mesh|Points), so I've added a dummyMesh that allows the Godrays effect to have a temporary placeholder. It's then modified by the real value of props.lightSource when it's ready.