Change license.file to license-files + SPDX-compliance
#528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I encountered this issue when making a release astro-informatics/sleplet#451
matt-graham
approved these changes
Apr 2, 2025
There was a problem hiding this comment.
Looks good to me.
In case helpful to anyone understanding why this change is required, relevant part of Python Packaging User Guide documentation says that
As per PEP 639 licenses should be declared with two fields:
licenseis an SPDX license expression consisting of one or more license identifiers.license-filesis a list of license file glob patterns.A previous PEP had specified license to be a table with a file or a text key, this format is now deprecated.
matt-graham
requested changes
Apr 2, 2025
matt-graham
requested changes
Apr 2, 2025
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
Co-authored-by: Matt Graham <matthew.m.graham@gmail.com>
|
https://stackoverflow.com is currently down |
I glanced over it initially, but yeah I think you are right, it does want both. It didn't error with just one, but did with the use of the old |
license.file to license-fileslicense.file to license-files + SPDX-compliance
samcunliffe
approved these changes
Apr 2, 2025
matt-graham
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this issue when making a release astro-informatics/sleplet#451. Also, make
BSD-3SPDX-compliant.