Fix Lfm::translateFromUtf8() to handle an array of strings and not only a string.
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve a crash (error 500) on Windows env, when doing a move operation.
Issue number: #739
Summary of the change: Make
translateFromUtf8()handle arrays of strings and not only a string.Notice that it is a similar proposition of the pull requests:
Fix error TypeError: mb_detect_encoding(): Argument #1 ($string) must be of type string, array given in file Lfm.php with change method translateFromUtf8 #1234, which didn't update the function header and also could potentially lose the array keys as it is not modifying the original array but creating a new one without re-using the original keys.
Fix Error - Windows - mb_detect_encoding - #739 #1014, which also doesn't correct the function header and creates a new array for nothing, also losing the original array keys.