Skip to content

Fix context value reference changing across rendering #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Fix context value reference changing across rendering #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7980125
feat: fix context value reference change across render
Criezc Mar 19, 2025
ad764a3
feat: update types
Criezc Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions src/FlagProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/** @format */

import React, { type FC, type PropsWithChildren, useEffect, useMemo, useState } from 'react';
import { type IConfig, UnleashClient } from 'unleash-proxy-client';
import React, { type FC, type PropsWithChildren, useCallback, useEffect, useMemo, useState } from 'react';
import { type IConfig, IMutableContext, UnleashClient } from 'unleash-proxy-client';
import FlagContext, { type IFlagContextValue } from './FlagContext';

export interface IFlagProvider {
Expand Down Expand Up @@ -106,20 +106,40 @@ const FlagProvider: FC<PropsWithChildren<IFlagProvider>> = ({
};
}, []);

const on = useCallback<IFlagContextValue['on']>(client.current.on, []);

const off = useCallback<IFlagContextValue['off']>(client.current.off, []);

const isEnabled = useCallback<IFlagContextValue['isEnabled']>(
(toggleName: string) => client.current.isEnabled(toggleName),
[]
)

const updateContext = useCallback<IFlagContextValue['updateContext']>(
async (context: IMutableContext) =>
await client.current.updateContext(context),
[]
)

const getVariant = useCallback<IFlagContextValue['getVariant']>(
(toggleName: string) => client.current.getVariant(toggleName),
[]
)

const context = useMemo<IFlagContextValue>(
() => ({
on: ((event, callback, ctx) => client.current.on(event, callback, ctx)) as IFlagContextValue['on'],
off: ((event, callback) => client.current.off(event, callback)) as IFlagContextValue['off'],
updateContext: async (context) => await client.current.updateContext(context),
isEnabled: (toggleName) => client.current.isEnabled(toggleName),
getVariant: (toggleName) => client.current.getVariant(toggleName),
on,
off,
updateContext,
isEnabled,
getVariant,
client: client.current,
flagsReady,
flagsError,
setFlagsReady,
setFlagsError,
}),
[flagsReady, flagsError]
[flagsReady, flagsError, on, off, updateContext, isEnabled, getVariant]
);

return (
Expand Down