fix: cross platform uuid #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
commented
Jan 16, 2025
| * | ||
| * We use it for connection id generation which is not critical for security. | ||
| */ | ||
| export const uuidv4 = (): string => { |
There was a problem hiding this comment.
existing tests check uuid is 36 characters
thomasheartman
previously approved these changes
Jan 16, 2025
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
thomasheartman
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
UUID generation with crypto has better uniqueness guarantees, but Math.random() solution is good enough for our use case (which is not security critical) and works better across all platforms.
This PR will fix the NextJS SDK build issue.
We use UUID for estimated connection counting which is using imprecise HyperLogLog anyway.
Important files
Discussion points