Skip to content

Small fixes #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Small fixes #219

merged 3 commits into from
Sep 1, 2022

Conversation

ivanklee86
Copy link
Collaborator

@ivanklee86 ivanklee86 commented Sep 1, 2022

Description

  • Fixes new lint error in CI/CD by adding timeout to cache bootstraping.
  • Attempts to only run notifications on PRs from not-forks (otherwise people's good PRs fail b/c they don't have access to webhook).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests
  • Spec Tests
  • Integration tests / Manual Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivanklee86 ivanklee86 enabled auto-merge (squash) September 1, 2022 12:21
@ivanklee86 ivanklee86 disabled auto-merge September 1, 2022 12:22
@ivanklee86 ivanklee86 merged commit 1861dd9 into main Sep 1, 2022
@ivanklee86 ivanklee86 deleted the il-small-fixes-20220901 branch September 1, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant