feat: add metrics metadata #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
sighphyre
commented
Jul 25, 2024
| @@ -41,22 +43,26 @@ def register_client( | |||
| :param request_timeout: | |||
| :return: true if registration successful, false if registration unsuccessful or exception. | |||
| """ | |||
| registation_request = { | |||
| registration_request = { | |||
There was a problem hiding this comment.
Not related to this PR but the spelling is driving me mad and I was in the neighborhood
ivanklee86
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metadata to registration and metrics, this doesn't affect the public API or internal workings, really, it just allows the Unleash server to get better insights into what the connected SDKs are up to in the wild