Skip to content

Feat: Add condition service tag to Unleash client #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Feat: Add condition service tag to Unleash client #77

merged 2 commits into from
Apr 15, 2025

Conversation

RikudouSage
Copy link
Collaborator

@RikudouSage RikudouSage commented Apr 11, 2025 •
edited
Loading

Description

Marks the Unleash client service with routing.condition_service which makes it possible to use it in routing conditions. Must be merged after #78.

Fixes #76

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Integration tests / Manual Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RikudouSage RikudouSage requested a review from sighphyre April 11, 2025 11:49
@RikudouSage RikudouSage mentioned this pull request Apr 11, 2025
Merged
8 tasks
sighphyre
sighphyre approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from New to Approved PRs in Issues and PRs Apr 14, 2025
@RikudouSage RikudouSage merged commit bbfef7b into main Apr 15, 2025
2 checks passed
@RikudouSage RikudouSage deleted the feat/routing-condition-service branch April 15, 2025 10:14
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: add routing.condition_service tag to the Unleash service to allow using with routing conditions
2 participants
@RikudouSage @sighphyre