Skip to content

Mock/fake version of UnleashClient #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
acsbendi opened this issue Jan 22, 2025 · 3 comments
Open

Mock/fake version of UnleashClient #241

acsbendi opened this issue Jan 22, 2025 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pinned

Comments

@acsbendi
Copy link

Describe the feature request

Similarly to the Java library's FakeUnleash, it would be useful to have an official way to easily mock the UnleashClient of this library.

Background

We would like to set enabled feature toggles from integration tests without having to implement a FakeClient in our own code.

Solution suggestions

Similarly to the Java version: define common interface, FakeUnleash implements it too, and it uses a completely local state so that enabled feature toggles can be set from the code.
@acsbendi acsbendi added the enhancement New feature or request label Jan 22, 2025
@gastonfournier gastonfournier added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 23, 2025
@gastonfournier gastonfournier moved this from New to For later in Issues and PRs Jan 23, 2025
@gastonfournier
Copy link
Contributor

Hi @acsbendi, thanks for the suggestion. It would be nice to have, but unfortunately not in our priorities at this moment. We'd be happy to review and provide support in case you want to make a contribution.

@gastonfournier gastonfournier mentioned this issue Jan 23, 2025
Closed
@stale Stale
Copy link

stale bot commented Feb 22, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 22, 2025
@stale stale bot closed this as completed Apr 27, 2025
@github-project-automation github-project-automation bot moved this from For later to Done in Issues and PRs Apr 27, 2025
@acsbendi
Copy link
Author

Please reopen, still not fixed

@github-project-automation github-project-automation bot moved this from Done to New in Issues and PRs Apr 28, 2025
@gastonfournier gastonfournier moved this from New to For later in Issues and PRs Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pinned
Projects
Issues and PRs
Status: For later
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gastonfournier @acsbendi