feat: default session id #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,7 +62,7 @@ public class UnleashClientBase { | |||
| self.metrics = Metrics(appName: appName, metricsInterval: Double(metricsInterval), clock: { return Date() }, disableMetrics: disableMetrics, poster: urlSessionPoster, url: url, clientKey: clientKey, customHeaders: customHeaders, connectionId: connectionId) | |||
| } | |||
|
|
|||
| self.context = Context(appName: appName, environment: environment) | |||
| self.context = Context(appName: appName, environment: environment, sessionId: String(Int.random(in: 0..<1_000_000_000))) | |||
There was a problem hiding this comment.
QQ is calculateContext overriding the sessionId with the providedContext session id (if present)?
kwasniew
commented
Apr 23, 2025
| @@ -192,12 +192,14 @@ public class UnleashClientBase { | |||
| properties?.forEach { (key, value) in | |||
| newProperties[key] = value | |||
| } | |||
|
|
|||
| let sessionId = context["sessionId"] ?? self.context.sessionId; | |||
There was a problem hiding this comment.
@gastonfournier here's the override if present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Provide default session id if there's no session id from the user context. The session is is only consistent within the same process. To persist session across different process runs we'd need to put it into a storage. Our storage is only working with flags for now so it's a bigger change.
The reason why the in-process stable session is still valuable is the reduction of 200 requests and increase of 304s instead. With no fixed session any multi variant flag invalidates the cache since you may get assigned variant a or b on each request.
Closes #119
Important files
Discussion points