feat: sdk type in metrics metadata #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
commented
Apr 29, 2025
| @@ -146,12 +146,19 @@ pub struct ClientApplication { | |||
| pub metadata: MetricsMetadata, | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)] | |||
There was a problem hiding this comment.
we can't derive builder on enums
kwasniew
commented
Apr 29, 2025
| @@ -417,6 +428,7 @@ mod tests { | |||
| "instanceId": "test-instance-id", | |||
| "connectionId": "test-connection-id", | |||
| "sdkVersion": "rust-1.3.0", | |||
| "sdkType": "backend", | |||
There was a problem hiding this comment.
lowercase from serde
There was a problem hiding this comment.
So.
If I remember correctly serde's rename lowercase doesn't work on enums. I think you have to use strum
#[strum(serialize_all = "lowercase")]
There was a problem hiding this comment.
Ah, but I see you have tests, ignore me then.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Modelling frontend and backend sdk type. This will be used by Unleash to handle frontend and backend apps separately.
Design decisions:
Important files
Discussion points