Added validation logic for e164 #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all message objects for the messages API use E164 validation.
Description
Facebook Messenger uses an ID. So, a new signature has been added to the interface for BaseMessage.
This is an internal change to validate something that would have triggered an error from the API anyway, and previously Messenger objects would not be sent. This is therefore not a breaking change but a bug fix.
Motivation and Context
Fixes #520
How Has This Been Tested?
The existing test suite needs to pass to show validation working when it needs to. Messenger test has been adjusted.
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: