Make connectedCallback property writable #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's up, thanks 👋 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thank you for this great library! It's really helpful for initializing WebComponent's child elements. Unfortunately, while playing with Github's Catalyst framework, I've noticed it's not possible to change a
connectedCallbackmethod from theHTMLParsedElement.Catalystrelies on overridingconnectedCallbackvia regular assignment operator so to make those two play nice together, I had to to change theconnectedCallbackproperty towritable.To make it easier to use
HTMLParsedElementwith 3rd party libraries, I'd like to suggest addingwritable: trueto theconnectedCallbackproperty.PS. In this PR, I've also fixed npm script to start server.