Skip to content

Enhanced User-Agent #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nerdguru opened this issue Apr 28, 2020 · 1 comment
Closed

Enhanced User-Agent #109

nerdguru opened this issue Apr 28, 2020 · 1 comment
Assignees

Comments

@nerdguru
Copy link
Contributor

Per the conversation @cmlccie and I had last week, the idea here is to enhance the information placed in the User-Agent HTTP Request header to be more like what pip does as can be seen here:

https://github.com/pypa/pip/blob/master/src/pip/_internal/network/session.py

In addition to the SDK version string, pip appends a URL encoded JSON string that includes things like OS version of the caller and Python version. It would be nice to also have a field in that string that partners could set that would identify API calls made by them. I just forked the repo and am working on a patch for this exact scenario.

nerdguru added a commit to nerdguru/webexteamssdk that referenced this issue Apr 29, 2020
@cmlccie cmlccie added this to the v1.x milestone Jul 7, 2020
@cmlccie cmlccie self-assigned this Jul 8, 2020
@cmlccie cmlccie linked a pull request Jul 8, 2020 that will close this issue
@cmlccie
Copy link
Collaborator

cmlccie commented Jul 9, 2020

Released in v1.5 #124.

@cmlccie cmlccie closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants