Skip to content

Add TrackingId to ApiError message. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sQu4rks opened this issue May 6, 2020 · 2 comments · Fixed by #121
Closed

Add TrackingId to ApiError message. #112

sQu4rks opened this issue May 6, 2020 · 2 comments · Fixed by #121
Assignees
@cmlccie
Labels
enhancement

Comments

@sQu4rks
Copy link
Contributor

sQu4rks commented May 6, 2020

Since the tracking id is a great way for the support team to troubleshoot issues what do you think about including it in the error message of the ApiError?

While you can access it via the response property of the ApiError this option is only accessible when actually catching the error.
@cmlccie cmlccie added this to the v1.x milestone Jul 7, 2020
@cmlccie
Copy link
Collaborator

cmlccie commented Jul 8, 2020

Great idea. This will definitely help improve the transparency of the API responses and errors.

I'm on it, and I'd love your feedback. I'll submit a PR for you to review.

@cmlccie cmlccie self-assigned this Jul 8, 2020
@cmlccie cmlccie linked a pull request Jul 8, 2020 that will close this issue
Add Tracking IDs to all API Errors and Warnings #121
Merged
@sQu4rks
Copy link
Contributor Author

sQu4rks commented Jul 9, 2020

I just merged the PR. Closing this issue.

@sQu4rks sQu4rks closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmlccie cmlccie

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Tracking IDs to all API Errors and Warnings WebexCommunity/WebexPythonSDK
2 participants
@sQu4rks @cmlccie