Skip to content

possible bug with rooms.get #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradh11 opened this issue Jun 1, 2020 · 2 comments · Fixed by #117
Closed

possible bug with rooms.get #114

bradh11 opened this issue Jun 1, 2020 · 2 comments · Fixed by #117
Assignees
@sQu4rks
Labels
bug

Comments

@bradh11
Copy link

bradh11 commented Jun 1, 2020 •
edited
Loading

when running api.rooms.get(roomId='myroomid') i am seeing that the class object gets all attributes from _json_data except ownerId. I am trying to leverage the SDK to check for rooms within an organization and think it would be easier if i didnt have to fetch the ownerId from inside the _json_data dictionary within the class object for the returned room.

Screenshot below shows the attribute in the dict but not in the root object.
image

is this a bug, or by design?
@sQu4rks
Copy link
Contributor

sQu4rks commented Jun 17, 2020

Not by design @bradh11. Thanks for raising this. I'll be adding it to the property list and create a PR so that it is included in the next release. In the meantime you can just access the property over the dict itself.

@sQu4rks sQu4rks self-assigned this Jun 17, 2020
@sQu4rks sQu4rks added the bug label Jun 17, 2020
sQu4rks added a commit to sQu4rks/WebexPythonSDK that referenced this issue Jun 18, 2020
@sQu4rks
Added ownerId to property list - resolves issue WebexCommunity#114
574316d
@sQu4rks
Copy link
Contributor

sQu4rks commented Jun 18, 2020

Hi @bradh11

I have added the ownerId to the property list of the room object. You can try the code by installing my development branch (pip3 install git+https://github.com/sQu4rks/webexteamssdk@issue-114) or wait until the PR gets merged and a new release gets pushed.

Let me know if this resolves your issue.

@sQu4rks sQu4rks mentioned this issue Jun 18, 2020
Merged
@sQu4rks sQu4rks linked a pull request Jun 18, 2020 that will close this issue
Added ownerId to property list of room #117
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sQu4rks sQu4rks

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ownerId to property list of room sQu4rks/WebexPythonSDK
2 participants
@sQu4rks @bradh11