Skip to content

Fixed simple property rendering (fixes CiscoDevNet/webexteamssdk#107) #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

sQu4rks
Copy link
Contributor

@sQu4rks sQu4rks commented Jul 9, 2020

Simple properties are no longer forced into a string representation
and thus retain their original data type (i.e. booleans or numbers).
Only exception are all option enums that are converted into their
string representation.

Simple properties are no longer forced into a string representation
and thus retain their original data type (i.e. booleans or numbers).
Only exception are all option enums that are converted into their
string representation.
Copy link
Collaborator

@cmlccie cmlccie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We could use some unit tests for the adaptive cards, and this could wait until v2.x potentially with a refactor to use pydantic models.

@cmlccie cmlccie changed the base branch from master to v1.x July 9, 2020 14:33
@cmlccie cmlccie merged commit 54d3f68 into WebexCommunity:v1.x Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'isSubtle' and possibly other boolean cards properties are not handled properly Cards example doesn't work
2 participants