Remove backslash from f-string (Patch for Issue: #247) #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove backslash from f-string to maintain backward compatibility with Python 3.10 and 3.11 versions. Also, corrected little (very minor non-impacting) cosmetic issues.
|
Hello Sakthivel, unfortunately, when I am running the test suite on this PR, it is failing a lot of tests. Can you work with the test suite? let me know the output? |
"make format" runs
|
Hi Joe, The test suites have passed now. Thanks, |
|
Passed on my end as well. Thanks!! |
Sakthivel-Ramasamy
pushed a commit
to Sakthivel-Ramasamy/webex_bot_forked
that referenced
this pull request
Jan 11, 2025
Updated webexpythonsdk library version to 2.0.3 which has the fixed the Python 3.10 and 3.11 version backward compatibility issue, introduced by webexpythonsdk 2.0.2 release (WebexCommunity/WebexPythonSDK#248).
fbradyirl
added a commit
to fbradyirl/webex_bot
that referenced
this pull request
Apr 24, 2025
* Updated webexpythonsdk library version Updated webexpythonsdk library version to 2.0.3 which has the fixed the Python 3.10 and 3.11 version backward compatibility issue, introduced by webexpythonsdk 2.0.2 release (WebexCommunity/WebexPythonSDK#248). * Corrected webexpythonsdk version requirement Pointed webex_bot to always use webexpythonsdk 2.0.3 or higher * Update setup.py Point "setup.py" to exact latest webexpythonsdk version Co-authored-by: FB <fbradyirl@users.noreply.github.com> * Update requirements_dev.txt Point "requirements_dev.txt" to exact latest webexpythonsdk version Co-authored-by: FB <fbradyirl@users.noreply.github.com> * Update README.md Updated README.md file for instructions on using new webex_bot 0.6.0 version * Update references to Python version Updated references to Python version * Updated webexpythonsdk to latest version Updated webexpythonsdk to latest version 2.0.4 --------- Co-authored-by: Sakthivel Ramasamy (sakthram) <sakthram@cisco.com> Co-authored-by: FB <fbradyirl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove backslash from f-string to maintain backward compatibility with Python 3.10 and 3.11 versions.
Also, corrected little (very minor non-impacting) cosmetic issues.
Patch for Issue: #247