Change contributing workflow #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…XRPL-Standards into df/update-process # Conflicts: # CONTRIBUTING.md
…XRPL-Standards into df/update-process # Conflicts: # .gitignore
Update Submission Process
…ange-contributing-workflow # Conflicts: # .gitignore # README.md
|
Bumping this once more - I realize these changes are quite old, so am open to feedback, suggestions, debate, etc.
|
mvadari
reviewed
Apr 11, 2024
mvadari
approved these changes
Apr 11, 2024
ximinez
reviewed
Apr 12, 2024
Remove period from anchor link Co-authored-by: Ed Hennis <ed@ripple.com>
mvadari
approved these changes
Apr 17, 2024
amarantha-k
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Thanks for the updates, @sappenin! Other than a minor suggestion, looks good.
Co-authored-by: Amarantha Kulkarni <amarantha-k@users.noreply.github.com>
intelliot
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-organizes the Contributing guidelines to reflect the process agreed upon by @Silkjaer, @intelliot , @sappenin, @amarantha-k and a few others in April of 2023 (but which was never update in this repo).
Given that it has unfortunately been some time since this discussion took place, if you would like to propose any changes to this PR, please feel free.