Support python 3.12 #75
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bump virtualenv to have a new enough pip in virtualenv - upgrade xxhash to support python 3.12
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Python 3.12 by removing the kafka.vendor.six compatibility layer that was causing import errors, since Python 2 support is no longer needed. The PR modernizes the codebase to use Python 3's standard library directly.
- Removes all
kafka.vendor.siximports and replaces them with Python 3 standard library equivalents - Updates CI/testing configuration to support Python 3.10-3.12 and drops older Python versions
- Fixes a broken test assertion and unconditionally skips a failing test
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Updates Python version matrix to 3.10-3.12 and removes Yelp-specific configuration |
| test/test_producer_legacy.py | Replaces kafka.vendor.six.moves.queue with standard queue import |
| test/test_producer_integration.py | Removes unused kafka.vendor.six.moves.range import |
| test/test_consumer_integration.py | Removes unused range import and unconditionally skips failing test |
| test/test_codec.py | Removes unused range import |
| test/test_client_async.py | Fixes broken test assertions and adds missing mock import |
| test/fixtures.py | Replaces six urllib imports with standard library equivalents |
| setup.py | Sets minimum Python version requirement to 3.10 |
| requirements-dev.txt | Updates package versions for Python 3.10-3.12 compatibility |
| kafka/version.py | Bumps version number |
| kafka/producer/simple.py | Removes unused range import |
| kafka/msk.py | Replaces six urllib import with standard library |
| kafka/consumer/simple.py | Replaces six imports with standard library equivalents |
| kafka/consumer/multiprocess.py | Replaces six queue import with standard library |
| kafka/codec.py | Removes six compatibility code and unused imports |
| Makefile | Simplifies test command to use tox.ini configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nleigh
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue here is that for somewhat unclear reasons
kafka.vendor.sixresults in an import error under python 3.12. Since none of that is necessary in python 3--which in a practical sense is all we support--I just removed it, unblocking python 3.12.As a matter of course I did a few other things:
make testnow relies on the tox.ini envlist instead of hardcoding a different list